RFR: 8345678: compute_modifiers should not be in create_mirror

[Coleen Phillimore]

On Mon, 9 Dec 2024 13:00:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/classfile/javaClasses.cpp line 1119:
>> 
>>> 1117:   // to support Class.getModifiers().  Instance classes recalculate
>>> 1118:   // the cached flags after the class file is parsed, but before the
>>> 1119:   // class is put into the system dictionary.
>> 
>> Is this comment already out-of-date? I'm trying to see where the flags are recomputed after parsing.
>
> I thought the comment was referring to this code below that late calculates the modifier flags.  Don't know why system dictionary was called out though.

And they're not the same as access flags.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22618#discussion_r1875957344