RFR: 8342995: Enhance Attach API to support arbitrary length arguments - Linux

[Alex Menkov]

On Mon, 9 Dec 2024 17:01:40 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> VirtualMachineImpl.java and attachListener_PLATFORM.cpp have much in common between platforms, but maybe creating new common base classes is an interesting refactor work with not that much payoff.

Yes, there a lot of common code between platforms and it can be refactored, but it would make the fix much bigger and harder to review.

> Plus there are AIX versions that some of us don't build and test (which I think you mentioned elsewhere).

Right. Most of the AIX code is copy of the posix/linux/macosx implementation, but I have no environment to build/test it, so I changed shared code to not break AIX build.

> On Windows, attachListener_windows.cpp operations have: assert(opened(), "must be"); ...I was wondering if we don't need a similar assert in in src/hotspot/os/posix/attachListener_posix.cpp But probably the different usage pattern explains that, i.e. Windows' PipeChannel needs the open() method specifically called, but for Posix it creates the socket on construction.

Right. The assert can be added to posix implementation, but it doesn't make much sense as SocketChannel does not opens the socket, but get it from the caller

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22223#issuecomment-2529687621