RFR: 8345678: compute_modifiers should not be in create_mirror

[David Holmes]

On Tue, 10 Dec 2024 09:08:07 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> ObjArrayKlass computes the modifier flags based on the bottom_klass, and there is a place that calls compute_modifier_flags in an assert that requires the virtual function, albeit for an assert, otherwise I would have made it not a virtual function.
>
> Okay I see now - the access modifier part of the modifiers for a reference array comes from the element type.

But still "jvm support" in the comment really doesn't explain anything.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22618#discussion_r1877652152