RFR: 8345678: compute_modifiers should not be in create_mirror [v2]

[David Holmes]

On Tue, 10 Dec 2024 13:29:21 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This moves the modifier_flag computation to when InstanceKlass, ObjArrayKlass and TypeArrayKlass are created.
>> 
>> Tested with jck:vm and tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove "jvm support"

src/hotspot/share/oops/arrayKlass.hpp line 123:

> 121: 
> 122:   // jvm support
> 123:   jint compute_modifier_flags() const;

I would have expected this to be defined as a virtual function here and then overridden as needed by the various subclasses.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22618#discussion_r1878813713