RFR: 8345678: compute_modifiers should not be in create_mirror [v2]

[David Holmes]

On Wed, 11 Dec 2024 14:10:27 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> To be clear I would expect arrayKlass to define a pure virtual function for this, and then each subclass overrides as required. Otherwise you can't generally operate on an arrayKlass but must always know what subtype you are dealing with.
>
> Klass has a pure virtual function for this, so ArrayKlass is abstract.  There isn't a reason to redeclare it in ArrayKlass.
> 
>      virtual jint compute_modifier_flags() const = 0;

Sorry I didn't realize that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22618#discussion_r1881532974