RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest [v2]

[Alex Menkov]

On Fri, 13 Dec 2024 20:49:22 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback
>
> test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.java line 259:
> 
>> 257:                     + "' of " + classfileBuffer.length + " bytes.");
>> 258:             } catch (Throwable t) {
>> 259:                 // try to log, save the error for handling by main thread if the logging fails
> 
> Suggestion:
> 
>                 // Try to log. Save the error for handling by main thread if the logging fails.

Done

> test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.java line 261:
> 
>> 259:                 // try to log, save the error for handling by main thread if the logging fails
>> 260:                 try {
>> 261:                     transformerException.printStackTrace();
> 
> Isn't this suppose to be `t.printStackTrace()`?

Good catch!
Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22727#discussion_r1884580477
PR Review Comment: https://git.openjdk.org/jdk/pull/22727#discussion_r1884580327