RFR: 8346248: serviceability/dcmd/vm/{SystemMapTest.java,SystemMapTest.java} failing on macos-aarch64

[Stefan Karlsson]

On Mon, 16 Dec 2024 13:20:44 GMT, Simon Tooke <stooke at openjdk.org> wrote:

>> [JDK-8319875](https://bugs.openjdk.org/browse/JDK-8319875) updated jcmd System.map to support macOS but the tests are now failing on macosx-aarch64 with ZGC.
>> 
>> serviceability/dcmd/vm/SystemDumpMapTest.java
>> serviceability/dcmd/vm/SystemMapTest.java
>> 
>> test SystemMapTest.jmx(): failure
>> java.lang.RuntimeException: '0x\\p{XDigit}+-0x\\p{XDigit}+ +\\d+ +[\-rwx]*/[\-rwx]* +(pvt|tsh-shared) +(0x\\p{XDigit}+|\\d+) +JAVAHEAP.*' missing from stdout/stderr
>> at jdk.test.lib.process.OutputAnalyzer.shouldMatch(OutputAnalyzer.java:372)
>> at SystemMapTest.run(SystemMapTest.java:50)
>> at SystemMapTest.jmx(SystemMapTest.java:57)
>> 
>> The output from my runs says `tsh` and not `tsh-shared`. The following change seems to work on my machine and on macosx-aarch64 and macosx-x64 in our CI pipeline.
>> 
>> @stooke @tstuefe Do you think this looks reasonable or was there some systems that reported this as pvt-shared?
>
> (disclaimer - I am not a reviewer)
> 
> @stefank this looks right to me.  As part of the final refactoring, "-shared" was removed from the output, but the ZGC portion of the test was not updated.

@stooke Great, thanks! I'll get a Reviewer to review this and will push this ASAP.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22759#issuecomment-2545663911