RFR: 8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases [v5]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Dec 19 04:51:37 UTC 2024
On Wed, 18 Dec 2024 23:51:23 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review: removed unneeded check for JvmtiExport::can_post_frame_pop()
>
> src/hotspot/share/prims/jvmti.xml line 3096:
>
>> 3094: event will not be generated for any frames.
>> 3095: See the <eventlink id="FramePop"></eventlink> event for details.
>> 3096: <p/>
>
> I think
> `The specified thread must be suspended or must be the current thread.`
> should be added (as we have in `NotifyFramePop` description)
Nice catch, thanks. Fixed now. Fixed the CSR as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22744#discussion_r1891150755
More information about the serviceability-dev
mailing list