RFR: 8339113: AccessFlags can be u2 in metadata [v2]

[Coleen Phillimore]

On Thu, 19 Dec 2024 19:08:06 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp
>>    
>>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>>  - Update src/hotspot/share/opto/library_call.cpp
>>    
>>    Co-authored-by: David Holmes <62092539+dholmes-ora at users.noreply.github.com>
>
> src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp line 691:
> 
>> 689: 
>> 690:     // Skip if we don't have to unlock. (???is this right???)
>> 691:     rldicl_(R0, Raccess_flags, 64-JVM_ACC_SYNCHRONIZED_BIT, 63); // Extract bit and compare to 0.
> 
> Using `testbitdi` might make it more readable to non-experts.  It took me a while reading aix docs to realize that this platform numbers LSB as 63 and MSB/sign as 0.

yes I like testbitdi better.  I found a sample in the templateInterpreterGenerator code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22246#discussion_r1893099373