RFR: 8324539: Do not use LFS64 symbols in JDK libs [v4]
Magnus Ihse Bursie
ihse at openjdk.org
Thu Feb 1 14:27:15 UTC 2024
On Thu, 1 Feb 2024 13:47:45 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> After adding this additional patch I fully build fastdebug on AIX (hav to admit it does not look very nice).
>>
>>
>> diff --git a/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c b/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c
>> index 823475b0a23..ee0109b6806 100644
>> --- a/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c
>> +++ b/src/java.desktop/share/native/libawt/java2d/pipe/BufferedRenderPipe.c
>> @@ -31,6 +31,10 @@
>> #include "SpanIterator.h"
>> #include "Trace.h"
>>
>> +#if defined(_AIX) && defined(open)
>> +#undef open
>> +#endif
>> +
>> /* The "header" consists of a jint opcode and a jint span count value */
>> #define INTS_PER_HEADER 2
>> #define BYTES_PER_HEADER 8
>
>> @MBaesken So my fix in [25c691d](https://github.com/openjdk/jdk/pull/17538/commits/25c691df823eb9d9db1451637f28d59dd9508386) did not help? Maybe then it is some other system library that drags in `fcntl.h`; I assumed it was stdlib or stdio. That header file includes way too much that it does not need, so we can surely strip it of even more standard includes if that is what is required to fix this.
>
>
> Unfortunately it did not help.
@MBaesken How annoying. :( I have now tried to remove *all* system includes from `debug_util.h`. Can you please try again building debug on AIX, to see if it works without the `#undef` in `BufferedRenderPipe.c`?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17538#issuecomment-1921455438
More information about the serviceability-dev
mailing list