RFR: JDK-8318566: Heap walking functions should not use FilteredFieldStream [v3]
Alex Menkov
amenkov at openjdk.org
Fri Feb 2 02:49:13 UTC 2024
On Thu, 1 Feb 2024 18:56:37 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> src/hotspot/share/prims/jvmtiTagMap.cpp line 453:
>>
>>> 451: InstanceKlass* super_klass = ik->java_super();
>>> 452: if (super_klass != nullptr) {
>>> 453: start_index += add_instance_fields(super_klass, start_index);
>>
>> Does hotspot have any rules against potentially very deep recursion that can overflow the stack?
>
> I looked at hotspot code and don't see "implementation limits" for level of inheritance, so it looks like a valid concern.
> Need to reimplement this without recursion.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17661#discussion_r1475451497
More information about the serviceability-dev
mailing list