RFR: JDK-8318566: Heap walking functions should not use FilteredFieldStream [v3]
Chris Plummer
cjplummer at openjdk.org
Fri Feb 2 03:04:02 UTC 2024
On Fri, 2 Feb 2024 02:49:13 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> FilteredFieldStream used by heap walking functions to iterate through klass/superclasses/interfaces fields are known to have poor performance (see [JDK-8317692](https://bugs.openjdk.org/browse/JDK-8317692) for details).
>> Heap walking API implementation is the last user of the klasses.
>> The fix reworks iteration through klass/superclasses/interfaces fields and drops FilteredFieldStream-related code.
>> Additionally removed/updated includes of reflectionUtils.hpp.
>>
>> Testing:
>> - tier1..4;
>> - test/hotspot/jtreg/vmTestbase/nsk/jvmti (contains tests for different heap walking functions);
>> - new test from #17580 (now the test runs several times faster).
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>
> jcheck
Looks good.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17661#pullrequestreview-1858174309
More information about the serviceability-dev
mailing list