RFR: JDK-8317636: Improve heap walking API tests to verify correctness of field indexes [v3]

Serguei Spitsyn sspitsyn at openjdk.org
Sat Feb 3 00:47:05 UTC 2024


On Fri, 2 Feb 2024 23:10:32 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> The fix adds new test for FollowReferences JVMTI function to verify correctness of reported field indexes.
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   indent

Marked as reviewed by sspitsyn (Reviewer).

test/hotspot/jtreg/serviceability/jvmti/FollowReferences/FieldIndices/libFieldIndicesTest.cpp line 64:

> 62: static bool is_static_field(JNIEnv* env, jclass klass, jfieldID fid) {
> 63:   enum {
> 64:    ACC_STATIC        = 0x0008,

Nit: Indent is 1 instead of 2.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17580#pullrequestreview-1860688173
PR Review Comment: https://git.openjdk.org/jdk/pull/17580#discussion_r1476897942


More information about the serviceability-dev mailing list