RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v14]

Suchismith Roy sroy at openjdk.org
Mon Feb 5 09:26:08 UTC 2024


On Mon, 5 Feb 2024 09:01:06 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change logging
>
> src/hotspot/os/aix/os_aix.cpp line 1183:
> 
>> 1181:   // If the load fails,we try to reload by changing the extension to .a for .so files only.
>> 1182:   if (result == nullptr) {
>> 1183:     if (strcmp(pointer_to_dot, ".so") == 0) {
> 
> We could possibly reach here with `pointer_to_dot` == nullptr. Invoking strcmp causes undefined behavior!

Yes. Do we exit when there is no extension in the file ..or we can just append an extension manually and let the program flow go through.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1477884033


More information about the serviceability-dev mailing list