RFR: 8325464: GCCause.java out of sync with gcCause.hpp
Stefan Karlsson
stefank at openjdk.org
Thu Feb 8 08:42:53 UTC 2024
On Thu, 8 Feb 2024 06:19:16 GMT, Yifeng Jin <duke at openjdk.org> wrote:
> These two files (`GCCause.java` and `gcCause.hpp`) should be in sync by design, see comments in these two files. However, some recent changes (e.g. [JDK-8240239](https://bugs.openjdk.org/browse/JDK-8240239)) to `gcCause.hpp` were not simultaneously reflected in `GCCause.java`. This patch updates `GCCause.java` to keep sync with latest `gcCause.hpp`.
Changes requested by stefank (Reviewer).
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/shared/GCCause.java line 65:
> 63: _z_allocation_stall ("Allocation Stall"),
> 64: _z_proactive ("Proactive"),
> 65: _z_high_usage ("High Usage"),
gcCause.hpp has the Shenandoah and ZGC blocks swapped. Could you fix it in this change as well?
-------------
PR Review: https://git.openjdk.org/jdk/pull/17766#pullrequestreview-1869553109
PR Review Comment: https://git.openjdk.org/jdk/pull/17766#discussion_r1482599594
More information about the serviceability-dev
mailing list