RFR: JDK-8311076: RedefineClasses doesn't check for ConstantPool overflow [v2]

Leonid Mesnik lmesnik at openjdk.org
Fri Feb 9 21:49:05 UTC 2024


On Fri, 9 Feb 2024 20:42:14 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> The fix adds check that merged constant pool does not overflow u2 (two-byte unsigned).
>> The check is added after merging `the_class` and `scratch_class` constant pools, but before rewriting constant pool references.
>> 
>> testing:
>>  - sanity tier1;
>>  - all RedefineClasses/RetransformClasses tests:
>>    - test/jdk/java/lang/instrument
>>    - test/hotspot/jtreg/serviceability/jvmti/RedefineClasses
>>    - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses
>>    - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RetransformClasses
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   logging on cp overflow

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17759#pullrequestreview-1873242113


More information about the serviceability-dev mailing list