RFR: JDK-8311076: RedefineClasses doesn't check for ConstantPool overflow [v2]

[Alex Menkov]

On Fri, 9 Feb 2024 03:27:54 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1828:
>> 
>>> 1826:   // ensure merged constant pool size does not overflow u2
>>> 1827:   if (merge_cp_length > 0xFFFF) {
>>> 1828:     return JVMTI_ERROR_INTERNAL;
>> 
>> Doesn't it make a sense to add some logging there so user could easier understand the problem?
>
> Seems like a good idea, you can use log_warning(redefine, class, constantpool)("...")

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17759#discussion_r1484834110