Withdrawn: 8321971: Improve the user name detection logic in perfMemory get_user_name_slow
duke
duke at openjdk.org
Wed Feb 14 18:47:58 UTC 2024
On Thu, 14 Dec 2023 10:13:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
> Can I please get a review of this change which proposes to improve the code in `get_user_name_slow` function, which is used to identify the target JVM owner's user name? This addresses https://bugs.openjdk.org/browse/JDK-8321971.
>
> As noted in that JBS issue, in its current form, the nested loop ends up iterating over the directory contents of `hsperfdata_xxx` directory and then for each iteration it checks if the name of the entry matches the pid. This iteration shouldn't be needed and instead one could look for a file named `<pid>` within that directory.
>
> No new test has been added, given the nature of this change. Existing tier1, tier2, tier3 and svc_tools tests pass with this change on Linux, Windows and macosx.
This pull request has been closed without being integrated.
-------------
PR: https://git.openjdk.org/jdk/pull/17104
More information about the serviceability-dev
mailing list