RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v4]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Feb 14 20:35:05 UTC 2024
On Wed, 14 Feb 2024 18:33:19 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>>> When you get the chance, can you checkout these possible
>> changes for the objmonusage001 test?
>>
>> Thanks, Dan. I've pushed the suggested test changes but refactored them a little bit.
>
>> Thanks, Dan. I've pushed the suggested test changes but refactored them a little bit.
>
> You are welcome. I presume the revised test passes with your fix in place. I made the
> test changes on a baseline repo and not a repo that had your changes which is why I
> had temporary debug flags in the test..
>
> Also, do you agree with my test assertion comments in the verification point comments?
> Am I properly understanding how we are changing this API?
>From @dcubed-ojdk :
> Also, do you agree with my test assertion comments in the verification point comments?
> Am I properly understanding how we are changing this API?
Yes, I agree. All looks right to me.
Q: Do you want to keep the `CHECK_FOR_BAD_RESULTS` mode or it can be removed after the failing output was verified?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17680#issuecomment-1944545272
More information about the serviceability-dev
mailing list