RFR: JDK-8176520: Improve the accuracy of the instance size in hprof heap dumps [v2]

[Alex Menkov]

On Thu, 15 Feb 2024 04:04:19 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> The test is odd in a couple of ways. The first is it's in the SA test directory, yet is also meant as a VM heap dump test. If someone were to make changes to the VM heapdump code and run the VM heapdump tests, this test would not get run. The other oddity is that it is not testing if the hprof file is correct. It is instead testing if SA and the VM produce the same result. Although that is a valid thing to test for, it seems correctness should also be tested for.

Ok, then I think the test should be split on 2 tests
One in test/hotspot/jtreg/serviceability/HeapDump to test VM dumper only (verifies correctness, checks that instance size for all instance klasses >0);
Another one in the SA test directory, tests VM and SA heap dumpers consistency (equal instance size for the same classes)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17855#issuecomment-1947637329