RFR: 8325950: Make sure all files in the JDK pass jcheck [v2]

Naoto Sato naoto at openjdk.org
Fri Feb 16 16:55:57 UTC 2024


On Fri, 16 Feb 2024 12:43:25 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> Since jcheck only checks file in a commit, there is a possibility of us getting files in the repository that would not be accepted by jcheck. This can happen when extending the set of files checked by jcheck, or if jcheck changes how it checks files (perhaps due to bug fixes).
>> 
>> I have now run jcheck over the entire code base, and fixed a handful of issues. With these changes, jcheck accept the entire code base.
>
> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replace spaces with \t in test properties file

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17871#pullrequestreview-1885586969


More information about the serviceability-dev mailing list