RFR: 8247972: incorrect implementation of JVM TI GetObjectMonitorUsage [v13]

[Serguei Spitsyn]

On Wed, 21 Feb 2024 22:36:31 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review: addressed minor issue with use of []; corrected the test desctiption
>
> test/hotspot/jtreg/serviceability/jvmti/GetObjectMonitorUsage/ObjectMonitorUsage.java line 72:
> 
>> 70:      * - zero threads waiting to be notified
>> 71:      */
>> 72:     static void test1(boolean isVirtual) throws Error {
> 
> no need to add throws for unchecked excption

Fixed, thanks.

> test/hotspot/jtreg/serviceability/jvmti/GetObjectMonitorUsage/libObjectMonitorUsage.cpp line 117:
> 
>> 115:       LOG(">>> [%2d]    owner: none (0x0)\n", count);
>> 116:     } else {
>> 117:       err = jvmti->GetThreadInfo(inf.owner, &tinf);
> 
> need to check err status.

Fixed, thanks.

> test/hotspot/jtreg/serviceability/jvmti/GetObjectMonitorUsage/libObjectMonitorUsage.cpp line 126:
> 
>> 124:         LOG(">>>       waiters:\n");
>> 125:         for (j = 0; j < inf.waiter_count; j++) {
>> 126:           err = jvmti->GetThreadInfo(inf.waiters[j], &tinf);
> 
> need to check err.

Done, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1498688861
PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1498690913
PR Review Comment: https://git.openjdk.org/jdk/pull/17680#discussion_r1498688037