RFR: 8326524: Rename agent_common.h

[Coleen Phillimore]

On Thu, 22 Feb 2024 19:38:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/agent_common/agent_common.h to
> agent_common.hpp.
> 
> The #include updates were performed mechanically, and builds would fail if
> there were mistakes.
> 
> The copyright updates were similarly performed mechanically. All but a handful
> of the including files have already had their copyrights updated recently,
> likely as part of JDK-8324681. The only change to the renamed file is a
> copyright update, since no code changes were required.
> 
> Testing: mach5 tier1

I have a suggestion that'll make this worth scrolling just once.

test/hotspot/jtreg/vmTestbase/nsk/jvmti/Deallocate/dealloc001/dealloc001.cpp line 28:

> 26: #include "jvmti.h"
> 27: #include "agent_common.hpp"
> 28: #include "JVMTITools.h"

Why don't you change all of these together?  It's the same or similar scrolling.

-------------

PR Review: https://git.openjdk.org/jdk/pull/17970#pullrequestreview-1896852273
PR Review Comment: https://git.openjdk.org/jdk/pull/17970#discussion_r1499878024