RFR: 8324680: Replace NULL with nullptr in JVMTI generated code

Alan Bateman alanb at openjdk.org
Sun Feb 25 10:55:58 UTC 2024


On Thu, 15 Feb 2024 08:46:43 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> This enhancement replaces uses of NULL with nullptr in the XML-description files for JVMTI. These are the files `hotsport/share/prims/jvmti.xml` and `hotspot/share/prims/jvmti*.xls`.
> 
> The following files are auto-generated from the `jvmti.xml` and `*.xsl files` in the `build/<CFG>/variant-server/gensrc/jvmtifiles': `jvmti.h`, `jvmti.html`, `jvmtiEnter.cpp`, `jvmtiEnterTrace.cpp`, `jvmtiEnv.hpp`
> 
> This addresses a category of NULL uses that wasn't dealt with by:
>  [JDK-8299837](https://bugs.openjdk.org/browse/JDK-8299837).
>  
>  Testing:
>    - TBD: run mach5 tiers1-3

JVMTI agents can be developed in C or C++. If I read this changes correctly, then this will replace all the NULLs in the generated spec with nullptr. I wonder if this needs some setup in the Introduction section, e.g. the Function Return Values subsection, to make this clear.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17866#issuecomment-1962892766


More information about the serviceability-dev mailing list