RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v25]

[Suchismith Roy]

On Sun, 25 Feb 2024 06:32:20 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>    remove space
>
> src/hotspot/os/aix/os_aix.cpp line 1173:
> 
>> 1171:   char* const pointer_to_dot = strrchr(file_path, '.');
>> 1172:   char const *old_extension = ".so";
>> 1173:   char const *new_extension = ".a";
> 
> Suggestion:
> 
>   char* const file_path = strdup(filename);
>   char* const pointer_to_dot = strrchr(file_path, '.');
>   const char old_extension[] = ".so";
>   const char new_extension[] = ".a";
>   STATIC_ASSERT(sizeof(old_exception) >= sizeof(new_exception));
> 
> and remove runtime-assert below

@tstuefe  done. Anyreason why we use [] instead of the pointer. Doesn't [] convert into *(baseaddress) ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1502454196