RFR: 8326524: Rename agent_common.h

Coleen Phillimore coleenp at openjdk.org
Mon Feb 26 13:48:59 UTC 2024


On Fri, 23 Feb 2024 04:29:47 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/Deallocate/dealloc001/dealloc001.cpp line 28:
>> 
>>> 26: #include "jvmti.h"
>>> 27: #include "agent_common.hpp"
>>> 28: #include "JVMTITools.h"
>> 
>> Why don't you change all of these together?  It's the same or similar scrolling.
>
> As I said in our private chat, I'll look at doing that for at least some of the remainder.  I already had this one
> queued up, tested, and ready to submit the PR when you made that suggestion.  But avoiding that scrolling
> is why I described how those updates were done.  If you believe the (implicit) suggestion in the PR description,
> you don't need to look at them at all, and can just find the renamed file in the file list at the left in the review
> window (so much less scrolling) and go look at it.

Sure, but can you do the rest at the same time since they're in mostly the same files?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17970#discussion_r1502640501


More information about the serviceability-dev mailing list