RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]

David Holmes dholmes at openjdk.org
Tue Feb 27 05:41:47 UTC 2024


On Tue, 26 Dec 2023 14:15:17 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

>> Hi,
>> 
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop documentation, but I couldn't find that. I confirmed that there is no such typo in this repository. So I thought there was no need to fix JFR.stop documentation.
>> 
>> I confirmed that the fixes are reflected and that all of the jdk_jfr tests pass.
>> 
>> Could someone please review it?
>
> Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8313710: jcmd: typo in the documentation of JFR.start and JFR.dump

These changes seem fine to me.

Hopefully @egahlin can also approve.

BTW please merge your branch with master so that it is up to date. Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16413#pullrequestreview-1902559381
PR Comment: https://git.openjdk.org/jdk/pull/16413#issuecomment-1965825683


More information about the serviceability-dev mailing list