RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v4]
Erik Gahlin
egahlin at openjdk.org
Tue Feb 27 09:47:49 UTC 2024
On Tue, 27 Feb 2024 08:06:18 GMT, Taizo Kurashige <duke at openjdk.org> wrote:
>> Hi,
>>
>> I fixed the typos for JFR.start and JFR.dump.
>> Acconding to issue's description, there is some typo in JFR.stop documentation, but I couldn't find that. I confirmed that there is no such typo in this repository. So I thought there was no need to fix JFR.stop documentation.
>>
>> I confirmed that the fixes are reflected and that all of the jdk_jfr tests pass.
>>
>> Could someone please review it?
>
> Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'openjdk:master' into JDK-8313710
> - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
> - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
> - 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump
Looks good. Thanks for fixing this. I can sponsor the change.
-------------
Marked as reviewed by egahlin (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16413#pullrequestreview-1903021556
More information about the serviceability-dev
mailing list