Integrated: 8324799: Use correct extension for C++ test headers
Kim Barrett
kbarrett at openjdk.org
Thu Feb 29 06:28:01 UTC 2024
On Wed, 28 Feb 2024 01:18:50 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change that renames some test .h files to .hpp. These
> files contain C++ code and should be named accordingly. Some of them contain
> uses of NULL, which we change to nullptr.
>
> The renamed files are:
>
> test/hotspot/jtreg/vmTestbase/nsk/share/aod/aod.h
> test/hotspot/jtreg/vmTestbase/nsk/share/jni/jni_tools.h
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.h
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/JVMTITools.h
> test/hotspot/jtreg/vmTestbase/nsk/share/native/nsk_tools.h
>
> test/lib/jdk/test/lib/jvmti/jvmti_thread.h
> test/lib/jdk/test/lib/jvmti/jvmti_common.h
> test/lib/native/testlib_threads.h
>
> The #include updates were performed mostly mechanically, and builds would fail
> if there were mistakes. The exception is test
> test/hotspot/jtreg/serviceability/jvmti/FollowReferences/FieldIndices/libFieldIndicesTest.cpp,
> which was added after I'd done the mechanical update, so was updated by hand.
>
> The copyright updates were similarly performed mechanically. All but a handful
> of the including files have already had their copyrights updated recently,
> likely as part of JDK-8324681.
>
> Thus, the only "interesting" changes are to the renamed files.
>
> Testing: mach5 tier1
This pull request has now been integrated.
Changeset: 998d0baa
Author: Kim Barrett <kbarrett at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/998d0baab0fd051c38d9fd6021628eb863b80554
Stats: 1538 lines in 731 files changed: 134 ins; 134 del; 1270 mod
8324799: Use correct extension for C++ test headers
Reviewed-by: jwaters, gli, coleenp, lmesnik
-------------
PR: https://git.openjdk.org/jdk/pull/18035
More information about the serviceability-dev
mailing list