RFR: 8322873: Duplicate -ljava -ljvm options for libinstrument

[David Holmes]

On Tue, 2 Jan 2024 21:44:04 GMT, Mikael Vidstedt <mikael at openjdk.org> wrote:

> The libinstrument library is linked against libjava and libjvm, twice. This is mostly harmless but Xcode 15.x generates a warning:
> 
> Creating support/modules_libs/java.instrument/libinstrument.dylib from 12 file(s)
> ld: warning: ignoring duplicate libraries: '-ljava', '-ljvm'
> 
> In particular, note that the `JDKLIB_LIBS` variable passed in to `LIBS` already contains the -ljava -ljvm options. Digging through the history it seems like this issue was introduced with [JDK-8141290](https://bugs.openjdk.org/browse/JDK-8141290).
> 
> Testing: tier1,builds-tier[2-5]

LGTM.

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17230#pullrequestreview-1801291647