RFR: 8322989: New test serviceability/HeapDump/FullGCHeapDumpLimitTest.java fails
Stefan Karlsson
stefank at openjdk.org
Thu Jan 4 10:04:21 UTC 2024
On Thu, 4 Jan 2024 08:01:57 GMT, Denghui Dong <ddong at openjdk.org> wrote:
> Hi,
>
> Please help review this patch that fixes the failures of FullGCHeapDumpLimitTest.java caused by passing other gc flags.
>
> Thanks.
I prefer if we stay away from using `@requires vm.flagless` if possible. For this test I think we can just add `@requires vm.gc.Serial`? Could you try that instead?
-------------
Changes requested by stefank (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17263#pullrequestreview-1803844916
More information about the serviceability-dev
mailing list