RFR: JDK-8319382: com/sun/jdi/JdwpAllowTest.java shows failures on AIX if prefixLen of mask is larger than 32 in IPv6 case [v3]

Alex Menkov amenkov at openjdk.org
Fri Jan 12 21:25:21 UTC 2024


On Fri, 12 Jan 2024 11:28:32 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> In parseAllowedMask in socketTransport.c, prefixLen of mask is compared with a maxValue (32 for IPv4, 128 otherwise).  This fails if it is larger than 32, because getaddrinfo seems to detect IPv4 family, if IPv6 address has set only some of the last 32 Bits. So we take the wrong maxValue.
>
> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
> 
>   following proposals of alexmenkov

src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c line 400:

> 398: /*
> 399:  * Input is in_addr just because all clients have it.
> 400:  */

The comment does not make sense anymore: in_addr represents IPv4 address, in6_addr represents IPv6 address.
Could you remove it please.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17374#discussion_r1450935959


More information about the serviceability-dev mailing list