RFR: 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed [v2]

Severin Gehwolf sgehwolf at openjdk.org
Tue Jan 23 09:45:30 UTC 2024


On Tue, 23 Jan 2024 01:58:40 GMT, sendaoYan <duke at openjdk.org> wrote:

>> 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
>
> sendaoYan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
>   
>   Signed-off-by: sendaoYan <yansendao.ysd at alibaba-inc.com>

Looks fine now.

test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java line 75:

> 73:             long count = Metrics.systemMetrics().getMemoryFailCount();
> 74: 
> 75:             // Allocate 512M of data

Suggestion: Amend the comment to `Allocate 512M of data in 1M chunks per iteration`

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17514#pullrequestreview-1838306348
PR Review Comment: https://git.openjdk.org/jdk/pull/17514#discussion_r1462991886


More information about the serviceability-dev mailing list