RFR: 8324582: Replace -Djava.util.concurrent.ForkJoinPool.common.parallelism to -Djdk.virtualThreadScheduler.maxPoolSize/parallelism in jvmti vthread tests [v2]

Chris Plummer cjplummer at openjdk.org
Wed Jan 24 20:45:26 UTC 2024


On Wed, 24 Jan 2024 20:21:39 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Some jvmti tests use
>> -Djava.util.concurrent.ForkJoinPool.common.parallelism
>> to control the pool of virtual threads. However, it is controlled by
>> jdk.virtualThreadScheduler.parallelism property.
>> 
>> The non-continuations implementation doesn't use any of these properties and it was just deleted.
>> 
>> I verified the fix using jcmd Thread.dump and ran all jvmti tests in the default configuration.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed.

VThreadStackRefTest.java and VThreadInHeapDump.java need copyright updates. Otherwise the changes look good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17547#pullrequestreview-1842335010


More information about the serviceability-dev mailing list