RFR: 8324668: JDWP process management needs more efficient file descriptor handling [v3]
Jaikiran Pai
jpai at openjdk.org
Sat Jan 27 13:09:45 UTC 2024
> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8324668?
>
> This change proposes to fix the issue in jdwp where when launching a child process (for the `launch=<cmd>` option), it iterates over an extremely large number of file descriptors to close each one of those. Details about the issue and the proposed fixed are added in a subsequent comment in this PR https://github.com/openjdk/jdk/pull/17588#issuecomment-1912256075. tier1, tier2 and tier3 testing is currently in progress with this change.
Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
- log a warning message if we fallback to slower logic of closing file descriptors
- ignore return values, cast to void
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17588/files
- new: https://git.openjdk.org/jdk/pull/17588/files/4a1155b6..af2472d4
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17588&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17588&range=01-02
Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/17588.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17588/head:pull/17588
PR: https://git.openjdk.org/jdk/pull/17588
More information about the serviceability-dev
mailing list