RFR: 8324668: JDWP process management needs more efficient file descriptor handling [v5]

[Jaikiran Pai]

On Tue, 30 Jan 2024 19:41:48 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   assert that we don't pass values higher than INT_MAX to close()
>
> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 139:
> 
>> 137:         LOG_MISC(("warning: failed to close file descriptors of"
>> 138:                   " child process optimally, falling back to closing"
>> 139:                   " %d file descriptors sequentially", (max_fd - i + 1)));
> 
> No one is ever going to see this. This logging is off by default, and when turned on goes to the logfile, not stdout or stderr. Perhaps ERROR_MESSAGE() would be better, which goes to stderr and also gives the option of aborting if the debug agent is launched with errorexit=y.

Thank you Chris for pointing to ERROR_MESSAGE(). I've updated the PR to use that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17588#discussion_r1472205736