RFR: 8324668: JDWP process management needs more efficient file descriptor handling [v6]
Chris Plummer
cjplummer at openjdk.org
Wed Jan 31 01:51:01 UTC 2024
On Wed, 31 Jan 2024 01:46:57 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8324668?
>>
>> This change proposes to fix the issue in jdwp where when launching a child process (for the `launch=<cmd>` option), it iterates over an extremely large number of file descriptors to close each one of those. Details about the issue and the proposed fixed are added in a subsequent comment in this PR https://github.com/openjdk/jdk/pull/17588#issuecomment-1912256075. tier1, tier2 and tier3 testing is currently in progress with this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> Chris' review suggestion - replace LOG_MISC with ERROR_MESSAGE
Looks good. Thanks for taking this on.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17588#pullrequestreview-1852749213
More information about the serviceability-dev
mailing list