RFR: 8324668: JDWP process management needs more efficient file descriptor handling [v6]

[Jaikiran Pai]

On Wed, 31 Jan 2024 06:28:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Chris' review suggestion - replace LOG_MISC with ERROR_MESSAGE
>
> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 100:
> 
>> 98:     if ((dp = opendir(FD_DIR)) == NULL) {
>> 99:         ERROR_MESSAGE(("failed to open dir %s while determining"
>> 100:                   " file descriptors to close for process %d", FD_DIR, getpid()));
> 
> Nit: indent of second line is now off - please align "

Done. PR has been update to fix this.

> src/jdk.jdwp.agent/unix/native/libjdwp/exec_md.c line 139:
> 
>> 137:         ERROR_MESSAGE(("failed to close file descriptors of"
>> 138:                   " child process optimally, falling back to closing"
>> 139:                   " %d file descriptors sequentially", (max_fd - i + 1)));
> 
> Nit: please realign lines on "

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17588#discussion_r1472430580
PR Review Comment: https://git.openjdk.org/jdk/pull/17588#discussion_r1472430298