RFR: JDK-8320005 : Allow loading of shared objects with .a extension on AIX [v13]

[Martin Doerr]

On Wed, 31 Jan 2024 13:17:21 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> J2SE agent does not start and throws error when it tries to find the shared library ibm_16_am.
>> After searching for ibm_16_am.so ,the jvm agent throws and error as dll_load fails.It fails to identify the shared library ibm_16_am.a shared archive file on AIX.
>> Hence we are providing a function which will additionally search for .a file on AIX ,when the search for .so file fails.
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   spelling

src/hotspot/os/aix/os_aix.cpp line 1176:

> 1174:   strncpy(file_path,filename, buffer_length + 1);
> 1175:   char* const pointer_to_dot = strrchr(file_path, '.');
> 1176:   assert(pointer_to_dot != nullptr, "Attempting to load a shared object without extension? %s", filename);

This should not only be an assertion. I think the check could be used instead of the strcmp below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16604#discussion_r1472813890