RFR: 8335370: Fix -Wzero-as-null-pointer-constant warning in jvmti_common.hpp

Kim Barrett kbarrett at openjdk.org
Wed Jul 3 02:22:28 UTC 2024


On Mon, 1 Jul 2024 04:14:13 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Please review this trivial change to the print_method function in
>> test/lib/jdk/test/lib/jvmti/jvmti_common.hpp.  It was passing 0 as the FILE*
>> argument to fflush, triggering -Wzero-as-null-pointer-constant if that warning
>> is enabled.  The change is to replace that 0 with nullptr.
>> 
>> This removes about 10% of the -Wzero-as-null-pointer-constant warnings when
>> building with that option.
>> 
>> Testing: mach5 tier1
>
> Marked as reviewed by jwaters (Committer).

Thanks for reviews @TheShermanTanker , @alexmenkov , and @sspitsyn .

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19962#issuecomment-2204917404


More information about the serviceability-dev mailing list