RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction
Kevin Walls
kevinw at openjdk.org
Wed Jul 3 15:21:43 UTC 2024
On Wed, 3 Jul 2024 13:58:51 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
> CmdLine::is_executable() looks wrong, surely an empty line is not executable.
>
> With this change, in DCmd::parse_and_execute() we will avoid needlessly entering the code block to try and execute the command.
>
> DCmd tests all good:
> make images test TEST="test/hotspot/jtreg/serviceability/dcmd test/jdk/sun/tools/jcmd"
Noticed this issue while reviewing https://github.com/openjdk/jdk/pull/19776
(but not directly related to that change).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20006#issuecomment-2206509147
More information about the serviceability-dev
mailing list