RFR: 8267887: RMIConnector_NPETest.java fails after removal of RMI Activation (JDK-8267123)
Chris Plummer
cjplummer at openjdk.org
Wed Jul 10 20:51:56 UTC 2024
On Fri, 5 Jul 2024 14:06:39 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
> The test test/jdk/javax/management/remote/mandatory/connection/RMIConnector_NPETest.java should be removed.
>
> This test was added when 6984520 was fixed in 6u25. It has been problemlisted since JDK-8267123 removed RMI Activation (it does not use RMI Activation, it just wanted something "RMI" to connect with).
>
> Looking at the change it tested, the code is no longer the same, and is no longer at risk of this NPE.
>
> The original NPE fix was to check that jxmServerviceURL was not null before calling methods on it, but the current RMIConnector.java does not make those same calls.
>
> It is best to remove the test and its problemlist entry.
Looks good.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20054#pullrequestreview-2170267350
More information about the serviceability-dev
mailing list