RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction

David Holmes dholmes at openjdk.org
Fri Jul 12 03:48:50 UTC 2024


On Fri, 12 Jul 2024 03:04:06 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> Do I understand this right that the suggestion is to add an explicit runtime check for non-emptiness and report an error if an empty line has been discovered? If so, then the `is_empty()`check can be removed from the `CmdLine::is_executable()`.

Basically yes. If the line can never be empty then assert that is the case.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20006#issuecomment-2224379855


More information about the serviceability-dev mailing list