RFR: 8334169: Long arguments of attach operation are silently truncated on Windows [v2]

[Alex Menkov]

On Fri, 12 Jul 2024 20:25:21 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   feedback
>
> test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 98:
> 
>> 96: 
>> 97:                 if (!flagValue.equals(actualValue)) {
>> 98:                     String msg = "Actual values is different: "
> 
> Suggestion:
> 
>                     String msg = "Actual value is different: "

This was fixed in the previous commit

> test/hotspot/jtreg/serviceability/attach/LongArgTest.java line 159:
> 
>> 157:     private static Test test(LingeredApp app) {
>> 158:         return new Test(app);
>> 159:     }
> 
> I think the method would be better off placed right after main().

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19780#discussion_r1676652083
PR Review Comment: https://git.openjdk.org/jdk/pull/19780#discussion_r1676652191