RFR: 8336289: Obliterate most references to _snprintf in the Windows JDK
Julian Waters
jwaters at openjdk.org
Sat Jul 13 05:14:52 UTC 2024
On Fri, 12 Jul 2024 19:18:09 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> This should be using `os::snprintf` rather than `snprintf`. Rationale is in the comment here:
>
> https://github.com/openjdk/jdk/blob/1f6e106b45e5109224e13d70f1a40c9e666ec2ab/src/hotspot/share/runtime/os.cpp#L118-L126
>
> And yes, I know there are lots of bare uses of snprintf (about 125?), including in shared code. That's why it isn't currently in the forbidden list. There's some cleanup to do there.
Ah, I'd assumed that the places where bare _snprintf was used had a reason for using it directly. I'll change all the usages in this Pull Request to use os::snprintf
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20153#issuecomment-2226776993
More information about the serviceability-dev
mailing list