RFR: 8335610: DiagnosticFramework: CmdLine::is_executable() correction

[David Holmes]

On Fri, 12 Jul 2024 09:41:04 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> The jump is from the fact that nobody currently creates an empty CmdLine, to a ruling that nobody ever can in the future.

No my point is either it is impossible to create an empty cmdline or else we should have a test that introduces one. If you cannot write such a test then it must be impossible. Hence we can assert that it cannot be empty. If worried about some future use then add a comment/check that would catch it.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20006#issuecomment-2227618338