RFR: 8334167: Test java/lang/instrument/NativeMethodPrefixApp.java timed out

[Alan Bateman]

On Mon, 15 Jul 2024 08:16:25 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Hello David,
> 
> > @jaikiran there is a lot of unrelated refactoring and style changes here that obscures what the actual fix is.
> 
> I've updated the PR to undo some of the cosmetic changes that were introduced to cleanup the code a bit. The updated state of the PR now just includes functional updates to the test to address the issue noted in the linked JBS.

Would it be possible to at least re-format the declaration of the "transform" method as it's very messy and hard to see what is declaration vs. body. The format that you had in the first iteration was helpful because it allowed us to clearly see what is in the declaration vs. body. I think I would do the same for the messy premain method but that can be cleanup/re-formatting for another day.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20154#issuecomment-2227969544