RFR: 8334167: Test java/lang/instrument/NativeMethodPrefixApp.java timed out [v3]

Jaikiran Pai jpai at openjdk.org
Mon Jul 15 10:21:23 UTC 2024


On Mon, 15 Jul 2024 10:05:24 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   better formatting for transform() method of the test's agent
>
> test/jdk/java/lang/instrument/NativeMethodPrefixApp.java line 50:
> 
>> 48:     // It assumes that a specific non-native library method will call a specific
>> 49:     // native method.  The below may need to be updated based on library changes.
>> 50:     static String goldenNativeMethodName = "fooBarNativeMethod";
> 
> The comment block above seems no longer applicable now this is not a library class method.

I've now updated the code comment to note what that constant is for.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20154#discussion_r1677605240


More information about the serviceability-dev mailing list