RFR: 8315884: New Object to ObjectMonitor mapping [v9]

Roman Kennke rkennke at openjdk.org
Tue Jul 16 12:46:55 UTC 2024


On Tue, 16 Jul 2024 12:37:43 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> Axel Boldt-Christmas has updated the pull request incrementally with 10 additional commits since the last revision:
>> 
>>  - Remove try_read
>>  - Add explicit to single parameter constructors
>>  - Remove superfluous access specifier
>>  - Remove unused include
>>  - Update assert message OMCache::set_monitor
>>  - Fix indentation
>>  - Remove outdated comment LightweightSynchronizer::exit
>>  - Remove logStream include
>>  - Remove strange comment
>>  - Fix javaThread include
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 776:
> 
>> 774:     movl(top, Address(thread, JavaThread::lock_stack_top_offset()));
>> 775: 
>> 776:     if (!UseObjectMonitorTable) {
> 
> Why is the mark loaded here in the !UOMT case, but later in the +UOMT case?

Ah I see, it is because we don't have enough registers. Right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20067#discussion_r1679316824


More information about the serviceability-dev mailing list