RFR: 8327054: DiagnosticCommand Compiler.perfmap does not log on output() [v3]

[Kevin Walls]

On Mon, 22 Jul 2024 13:45:49 GMT, Sonia Zaldana Calles <szaldana at openjdk.org> wrote:

>> Hi all, 
>> 
>> This is a small patch to address [8327054](https://bugs.openjdk.org/browse/JDK-8327054) making `CodeCache::write_perf_map` aware of which output stream errors and warning message should be going to.
>> 
>> Testing: 
>> - [x] Added test case passes. 
>> 
>> Thanks, 
>> Sonia
>
> Sonia Zaldana Calles has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adding comment

src/hotspot/share/code/codeCache.cpp line 1804:

> 1802:   fileStream fs(filename, "w");
> 1803:   if (!fs.is_open()) {
> 1804:     st->print_cr("Failed to create %s for perf map", filename);

Hi -- as this used to be "log_warning" and print something like:
  [1129077.636s][warning][codecache] Failed to create /x for perf map
..it should probably say:
  Warning: Failed to...etc...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20257#discussion_r1686652944